For me, all of my favorite teachers have had a few things in commmon, in order of importance:
1.) They actually care about and have a personal bond with the students.
2.) They know when to bend and when to uphold the rules.
3.) They know what they're talking about. Especially needed for their subject, but also for other areas of life.
4.) They grade somewhat harshly, but do so in order to make the students understand the material, not to make them feel bad.
4 1/2.) They don't like making kids feel bad, but they understand it's necessary in order to learn.
5.) They have a comeback for the kid who makes a snarky comment that makes the kid look bad, not the teacher.
I don't know about yours, but my school district is much too focused on making students feel good about themselves than on actually teaching them the material. We used to get gold seals for an all-A report card - they discontinued it because some kids felt bad they didn't get it. We've replaced the system of honoring the student with the highest GPA to honoring everyone with a 4.0 or above. At our school, we had 40 valedictorians last year. Utterly rediculous. Of course, instead of analyzing the problem, they concluded that there were so many valedictorians because an A+ was worth about 4.25, so they took away the A+, when the problem is that "valedictorian" refers to the (singular) person with the highest grade point, and not to anyone with a good grade.
If you're teaching student teachers, teach them this: They want to get to know the students and help them get good grades. It's good if the students feel good about themselves in your class, but that's a secondary goal of school. The primary goal is to learn.